Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Biome stripes should be optimized. #720

Open
IntegratedQuantum opened this issue Sep 14, 2024 · 0 comments
Open

Biome stripes should be optimized. #720

IntegratedQuantum opened this issue Sep 14, 2024 · 0 comments
Labels
contributor friendly this issue is limited in scope and/or knowledge of Cubyz internals, good for newcomers engine experimental a feature or idea that will require lots of experimentation optimization a performance problem that should be addressed or an optimization idea terrain
Milestone
Long-Term Goals

Comments

@IntegratedQuantum
Copy link
Member

Now that more biomes use it, specifically the lava_cave, this terrain feature has shown up in the profiler at around 10% contribution to the total time.
Specifically the @mod instructions seems to take the most of the time.
This could probably be fixed using integer math and approximating the modulo+compare with multiplication+bit masking+compare.

The relevant code is in server/terrain/chunkgen/TerrainGenerator.zig
@IntegratedQuantum IntegratedQuantum added contributor friendly this issue is limited in scope and/or knowledge of Cubyz internals, good for newcomers experimental a feature or idea that will require lots of experimentation optimization a performance problem that should be addressed or an optimization idea engine terrain labels Sep 14, 2024
@IntegratedQuantum IntegratedQuantum added this to the Long-Term Goals milestone Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributor friendly this issue is limited in scope and/or knowledge of Cubyz internals, good for newcomers engine experimental a feature or idea that will require lots of experimentation optimization a performance problem that should be addressed or an optimization idea terrain
Projects
None yet
Milestone
Long-Term Goals
Development

No branches or pull requests
1 participant
@IntegratedQuantum