gesture disambiguation fix #7
Conversation
|
@PiN73 hello |
|
@theSharpestTool |
|
@ultronnet @PiN73 please check, it is updated |
|
@theSharpestTool thank you for disambiguation solution and for the update! I'm going to merge and add make some changes to allow keeping old behavior or combining them |
| @@ -636,7 +636,7 @@ class _CupertinoBackGestureController<T> { | |||
| @required this.controller, | |||
| }) : assert(navigator != null), | |||
| assert(controller != null) { | |||
| navigator.didStartUserGesture(); | |||
| //navigator.didStartUserGesture(); | |||
There was a problem hiding this comment.
Can you clarify which use-case do you have with keyboard which needs this fix?
There was a problem hiding this comment.
@PiN73 If there are two pages with autofocused text in each. If the user navigates back from one page to another by swiping back, the field will lose autofocus. It was critical in my project
There was a problem hiding this comment.
I think we shouldn't disable these callbacks as it can break other things. If you want to allow focusing during user gesture, I think it would be better to patch _shouldIgnoreFocusRequest in widgets/routes.dart making it always return false whatever the value of userGestureInProgress is
There was a problem hiding this comment.
As widgets/routes.dart isn't a part of this package, I'm going to keep the original behavior
There was a problem hiding this comment.
I think we shouldn't disable these callbacks as it can break other things. If you want to allow focusing during user gesture, I think it would be better to patch _shouldIgnoreFocusRequest in widgets/routes.dart making it always return false whatever the value of userGestureInProgress is
What things it can break?
@theSharpestTool what if I still want the swipe gesture enabled at the first page of tabview?flutter: Gesture arena 140 ❙ ★ Opening new gesture arena.
|
fix #4 #1