Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Compile with PL/Scope" action: compiling private and public synonyms should be separate choices #57

Open
rvo-cs opened this issue Nov 2, 2022 · 1 comment
Assignees

Comments

@rvo-cs
Copy link
Contributor

rvo-cs commented Nov 2, 2022

As of v1.0.0, the "Compile Synonyms?" prompt controls recompilation of both private and public synonyms. It should be possible to distinguish between the two, by splitting this choice into 2 separate prompts, respectively labeled:

  • "Compile Public Synonyms?"
  • "Compile Private Synonyms?"

Reason: private synonyms are part of the target schema, whereas public synonyms are not; recompiling the latter is more likely to cause invalidations in other schemas (distinct from the target of the action), whereas recompiling private synonyms could result in invalidations in other schemas, but only indirectly. Therefore, handling the 2 separately would provide a greater degree of control.

Additionally, the default value of both prompts should be "No".

Reason; because of the potential for invalidations in other schemas, recompiling public synonyms should be left to users who know what they are doing, hence "No" by default. Using the same default for private synonyms would then be necessary, otherwise the dialog box of the action would seem inconsistent.

@PhilippSalvisberg
Copy link
Owner

Reason; because of the potential for invalidations in other schemas, recompiling public synonyms should be left to users who know what they are doing, hence "No" by default. Using the same default for private synonyms would then be necessary, otherwise the dialog box of the action would seem inconsistent.

As mentioned in #55 the scope of the public synonyms is reduced to objects of the current schema. So, the current user is responsible for this public synonym. If not, he should not have the rights to create and drop public synonyms.

Instead of splitting the the option into public and private synonyms I think about removing the option. It would be consistent with the other object types for which not such an option exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants