Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multishell ACT HSVS recon workflow uses SS3T response functions #137

Open
araikes opened this issue Oct 25, 2024 · 2 comments
Open

Multishell ACT HSVS recon workflow uses SS3T response functions #137

araikes opened this issue Oct 25, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@araikes
Copy link
Contributor

araikes commented Oct 25, 2024

@mattcieslak

In the process of testing things for all of the other issues over the last 24 hours, I noticed that mrtrix_multishell_msmt_ACT-hsvs uses dhollander for the response function estimation (using the SS3TDwiResponse) interface.

	 [Node] Setting-up "qsirecon_0_0_wf.sub-001_mrtrix_multishell_msmt_hsvs.sub_001_ses_01_dir_AP_run_001_space_T1w_desc_preproc_recon_wf.msmt_csd.estimate_response" in "/output/scratch/qsirecon_0_0_wf/sub-001_mrtrix_multishell_msmt_hsvs/sub_001_ses_01_dir_AP_run_001_space_T1w_desc_preproc_recon_wf/msmt_csd/estimate_response".
241025-10:53:46,553 nipype.workflow INFO:
	 [Node] Executing "estimate_response" <qsirecon.interfaces.mrtrix.SS3TDwi2Response>
241025-10:55:00,857 nipype.workflow INFO:

Given that msmt_5tt is a response function option, is there a specific rationale for using dhollander in the HSVS spec?

@araikes araikes added the bug Something isn't working label Oct 25, 2024
@mattcieslak
Copy link
Contributor

Luckily this one isn't a bug! When we added ss3t to the recon workflows, we learned that there was an updated dhollander method implemented in the ss3t fork. That method should be available in the mrtrix that is now included in the qsirecon container, so we should switch to explicitly use the mrtrix3 version unless ss3t is explicitly being requested.

@araikes
Copy link
Contributor Author

araikes commented Oct 25, 2024

Great. Just observed that and wasn't sure if it was intentional or a by product of other processes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants