Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields not working with zenith #8

Open
duarm opened this issue May 9, 2024 · 3 comments
Open

Shields not working with zenith #8

duarm opened this issue May 9, 2024 · 3 comments
Labels
help wanted Extra attention is needed other mod's bug

Comments

@duarm
Copy link

duarm commented May 9, 2024

Thanks for making botania combat!

Botaniacombat shields do not fit into the reforging table from zenith, e.g. elementium shield below cant fit into the empty slot

image

Every weapon works

image

Netherite shield from guarding and every shield from Epic Knights mod works no problem, it might be worth investigating those in order to find out why botaniacombat shields do not work

@Partonetrain
Copy link
Owner

I believe compatibility with reforging is determined by Zenith material rarity, which is determined from Zenith's config. I could be wrong, as it's been a long time since I used its forge equivalent.

@duarm
Copy link
Author

duarm commented May 9, 2024

I can override the type from each botaniacombat shield inside zenith's Adventure.cfg to SHIELD, it does fit into the reforging table, but it doesnt work, the item appears affixed (the name is different), but no extra stat or sockets are given.

@Partonetrain Partonetrain added the help wanted Extra attention is needed label May 9, 2024
@Partonetrain
Copy link
Owner

Could possibly be related to #12 and how FabricShieldLib shields don't extend ShieldItem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed other mod's bug
Projects
None yet
Development

No branches or pull requests

2 participants