-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork indicator that does not take up space but expands #9
Comments
Wouldn't it only push the view down below the last post before the fork, which wouldn't affect the reader? |
No. What can happen is this:
Granted, case 2 will be quite rare, but case 1 will be quite common. |
Ah I see, go with the small fork symbol solution then! |
@jims, what do you think about that solution? |
Yeah as long as it fits between paragraph margins its fine. We would also make the actual selection be an overlay then I suppose. On a side note, I'm not sure how much this will be an issue in practice actually, It might be that it is a very rare case that this actually happens. |
We need a fork indicator that does not take up space between the paragraphs. The reason for this is that the reader loads all threads in the background and then starts looking through incoming links for forks. When a fork is found, a fork indicator is added to the right place. If the fork indicator takes up more space than the regular space between paragraphs, the reader can start pushing your view around when you are reading as the text is shifted to make room for the fork indicators.
At the same time, we don't want the whitespace between paragraphs to be larger for between posts than it is within them as it disrupts the smooth reading experience.
One possible solution would be to have a fork indicator that is very small and half-faded so that it does not take up too much mind space. See image below:
This would then animate to expand into the selector.
@skoteskote what is your take on this?
The text was updated successfully, but these errors were encountered: