Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incoming links kill forks #10

Open
aerugo opened this issue Jun 2, 2020 · 1 comment
Open

Incoming links kill forks #10

aerugo opened this issue Jun 2, 2020 · 1 comment

Comments

@aerugo
Copy link

aerugo commented Jun 2, 2020

Some incoming links to threads with forks stop all forks in that thread from rendering.

Post A links to topic B, and topic B is the root of a fork-chain. Post A does not fork, and just links to topic B.

If the link to topic B from post A is a link to the root URL of the topic (https://bbu.world/t/collaborative-whaling/1039), then none of the forks render when topic B is shown in the reader.

If the link to post B from post A is a link to the fourth post in the topic (https://bbu.world/t/collaborative-whaling/1039) then the last fork is not loaded while the others are.

I suspect that this is a problem because post A contains videos, so that when the reader looks at the HTML for post A when loading topic B, it crashes before it gets to rendering the forks.

It's possible to hack this problem by linking post A to a non-existant post in topic B, for example (https://bbu.world/t/collaborative-whaling/1039/10) as topic B only has 4 replies.

As there is a hack around this it's possible to use the reader with this error, but as it produces some pretty confusing behavior, it should be fixed eventually.

@jims
Copy link
Collaborator

jims commented Jun 2, 2020

This is a side-effect of #1, so fixing that will fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants