Xenobiology camera runtime

[chuga-git]

Exploit Reports

• I confirm this issue is not an exploit. (Required)

BYOND Version

516

Issue Description

See runtime log below. Occurred twice on round 43042 on NSS Cyberiad.

Relevant proc, from xenobio_camera.dm

/datum/action/innate/hotkey_help/Activate()
	if(!target || !isliving(owner))
		return
	var/obj/machinery/computer/camera_advanced/xenobio/X = owner.machine
	to_chat(owner, "<b>Click shortcuts:</b>")
	to_chat(owner, "Shift-click a slime to pick it up, or the floor to drop all held slimes.")
	to_chat(owner, "Ctrl-click a slime to scan it.")
	to_chat(owner, "Alt-click a slime to feed it a potion.")
	to_chat(owner, "Ctrl-click or a dead monkey to recycle it, or the floor to place a new monkey.")
	to_chat(owner, "[X] now has [X.monkeys] monkeys left.")

Somehow, the user was able to trigger the innate action while owner.machine was null. Might be a lingering hud element that doesn't get immediately removed when the user stops using the machine.

What did you expect to happen?

No response

What happened instead?

No response

Why is this bad/What are the consequences?

No response

Steps to reproduce the issue.

Unknown

When did the problem start happening?

Unknown

Extra information

No response

Relevant log output/runtime error

[2024-12-20T05:32:35] Runtime in code/modules/research/xenobiology/xenobio_camera.dm:381: Cannot read null.monkeys
   proc name: Activate (/datum/action/innate/hotkey_help/Activate)
   usr: X (X) (/mob/living/carbon/human)
   usr.loc: The floor (176,74,2) (/turf/simulated/floor/plasteel)
   src: Hotkey Help (/datum/action/innate/hotkey_help)
   call stack:
   Hotkey Help (/datum/action/innate/hotkey_help): Activate
   Hotkey Help (/datum/action/innate/hotkey_help): Trigger
   Hotkey Help (/atom/movable/screen/movable/action_button): fire_action
   Hotkey Help (/atom/movable/screen/movable/action_button): Click
   X (/client): Click