Modsuit module layering on wrong layer

[Bm0n]

Exploit Reports

• I confirm this issue is not an exploit. (Required)

BYOND Version

515.1645

Issue Description

Modsuit modules (when they have additional sprites) are layered above almost everything else including in hand sprites.

Example:

This mirage grenade module for the security modsuit is layered above the riot shields in hand sprite on Paradise.

While on TG it is layered below the in hand sprite:

The offending proc is /obj/item/mod/module/proc/generate_worn_overlay(mob/living/carbon/human/user), more specifically how it draws modules onto the EFFECTS_LAYER in Paracode, EFFECTS_LAYER should not be used here as it is a very high layer.

TG solves this issue by layering the modules 0.1 above the standing layer of the modsuit.

What did you expect to happen?

For modsuit modules not to layer above in hand sprites

What happened instead?

Modsuit modules layered above in hand sprites

Why is this bad/What are the consequences?

Broken layer for sprites is bad

Steps to reproduce the issue.

Get a modsuit with module sprites

Wear it

See modules layered above in hands

When did the problem start happening?

Since we've had modsuits

Extra information

No response

Relevant log output/runtime error

No response