Drones lose respawnability for midrounds after ghosting, recycling, or clicking follow notification action button.

[warriorstar-orion]

Exploit Reports

• I confirm this issue is not an exploit. (Required)

BYOND Version

515.1642

Issue Description

Possibly adjacent to #23358

Drones are supposed to have respawnability so that they can roll for midrounds. However, a drone that ghosts or returns to the fab does not have TRAIT_RESPAWNABLE, so they don't even get notifications from SSghost_spawns.

I'm pretty sure this stanza is just wrong:

Paradise/code/modules/mob/dead/observer/observer_base.dm

Lines 237 to 241 in 253b7f1

	if(isdrone(M))//We do not punish maint drones for leaving early, *but* we don't want them ghosting, finding damage, respawning / rentering over and over.
	var/mob/dead/observer/ghost = ghostize(TRUE) // Keep them respawnable
	ghost.can_reenter_corpse = FALSE // but keep them out of their old body
	ghost.timeofdeath = world.time // Because the living mob won't have a time of death and we want the respawn timer to work properly.
	return

And I have no idea if it applies when a living mob is ghostized in response to clicking an action button, or if a drone recycles themselves.

What did you expect to happen?

Drones should be able to click follow actions or ghost/recycle while maintaining respawnability.

What happened instead?

Drone ghosts aren't eligible for midround rolls.

Why is this bad/What are the consequences?

Drones are supposed to have respawnability.

Steps to reproduce the issue.

Start DEVELOPMENT server as admin, join as a guest, ready up guest, observe admin, start round. Cryo as guest, spawn as drone. Use event manager to proc a Blob midround. As admin, click mouse roll button. Once spawned, as guest, click the follow notification button for the infected mouse. As blob, split or spawn a naut. As guest, observe that no notification is sent.

When did the problem start happening?

Dunno

Extra information

No response

Relevant log output/runtime error

No response