Admins can't send faxes

[Nerfection]

Exploit Reports

• I confirm this issue is not an exploit. (Required)

BYOND Version

515.1644

Issue Description

We can use the fax panel as normal all the way up until we send the fax, then the sound file plays at the target fax machine...but no paper comes out!

What did you expect to happen?

I expected the fax to print as normal

What happened instead?

the sound played but nothing came out. No fax!

Why is this bad/What are the consequences?

As an admin, faxing is my favourite way to interact with the crew.

Steps to reproduce the issue.

Easily reproducable - send a fax to the station from the fax panel

When did the problem start happening?

First noticed 1/2 months ago, but was told it was fine and working as intented, but it keeps happening (not all the time, but I'm unclear what makes it work/not)

Extra information

No response

Relevant log output/runtime error

[2024-10-24T21:38:05] Runtime in code/modules/paperwork/faxmachine.dm:332: undefined variable /obj/item/paper/var/message

[Tourte-Yaya]

more indepth runtime log:

[PhantornRU]

When there are many faxes from the central command, they duplicate all the faxes. This should not happen.

[PhantornRU]

#27230

[FunnyMan3595]

The runtime listed was caused by @leoworm 's #26953. It updated receivefax and print_fax to take a /datum/fax, rather than a piece of paper, but didn't update the calls in code/modules/admin/topic.dm.

[leoworm]

Ah, my bad, I tried to update all relevant calls, but must've missed that one. Admin faxes sometimes not sending properly from the fax panel was already an issue prior to my PR though afaik.