Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs/src/jump/README.md #123

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Conversation

odow
Copy link
Contributor

@odow odow commented Nov 6, 2023

Here are some changes, but others might be needed. I think this is going to take a few rounds of iteration. I don't think the footnotes will work.

x-ref jump-dev/JuMP.jl#3561

@DimitriAlston
Copy link
Member

I can remove the reference to the footnotes, if that's the issue.

@odow
Copy link
Contributor Author

odow commented Nov 7, 2023

The main issue was fixing the /> closing tags for img and p. You could also just use [1] etc without links to the bottom?

@DimitriAlston
Copy link
Member

I sent you a message on Slack. I think it would be easier to talk about this there, unless you have another preference.

@@ -1,46 +1,69 @@
<img src="https://github.com/PSORLab/EAGO.jl/blob/master/docs/src/assets/logo.png" width="75%" height="75%">
<img src="https://github.com/PSORLab/EAGO.jl/blob/master/docs/src/assets/logo.png" width="75%" height="75%"/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<img src="https://github.com/PSORLab/EAGO.jl/blob/master/docs/src/assets/logo.png" width="75%" height="75%"/>
```@raw html
<img src="https://github.com/PSORLab/EAGO.jl/blob/master/docs/src/assets/logo.png" width="75%" height="75%"/>
```

@DimitriAlston DimitriAlston merged commit bea34bd into PSORLab:master Nov 7, 2023
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants