Truncate description for shows with Apple feeds #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kookster
changed the title
svevang
reviewed
Sep 18, 2024
kookster
commented
Sep 18, 2024
kookster
commented
Sep 18, 2024
kookster
commented
Sep 18, 2024
kookster
commented
Sep 18, 2024
kookster
commented
Sep 18, 2024
| @@ -31,6 +33,10 @@ def self.model_name | |||
| Feed.model_name | |||
| end | |||
|
|
|||
| def publish_feeds | |||
| podcast&.publish! | |||
There was a problem hiding this comment.
As per suggestion, consolidating the "getting ready to publish to Apple" sort of logic in this class.
I wish I could just trigger a publish of the feed without even trying to publish to apple when this first gets created, and before we want to try and sync with apple...maybe I will add a way to do that, but not sure how to decouple those in the current job?
kookster
commented
Sep 18, 2024
svevang
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes most of #1090
The RSS truncate depends there being an apple_config - not necessarily fully publishing yet, just a config exists.
I think that should allow for these legacy shows to regenerate the public RSS with truncated descriptions for Apple to re-ingest before we try to sync episodes. Luckily, probably not that many feeds like this - just need some way to get those old shows working.