Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameter for corpusdir location in plos_corpus.py #15

Open
eseiver opened this issue Oct 2, 2017 · 1 comment
Open

parameter for corpusdir location in plos_corpus.py #15

eseiver opened this issue Oct 2, 2017 · 1 comment
Assignees
Labels

Comments

@eseiver
Copy link
Collaborator

eseiver commented Oct 2, 2017

In preparation for pip install allofplos, there needs to be a way for the user to specify the path to corpusdir. Right now, the xml folder is created within the repository, and most people won't want to store datasets with executables. Some ideas:

  • default corpusdir location that would work across platforms, or change depending on OS (~/Documents/ ?)
  • request and store user input for the path to corpusdir, default to cwd/pwd
@eseiver
Copy link
Collaborator Author

eseiver commented Feb 15, 2018

This was partially addressed in #70 with the PLOS_CORPUS environmental variable, but it doesn't store permanently since it's using os.environ. Also worth noting that the default corpusdir location is no big deal for a cloned repo, but for the pip install it will wipe any directory in location whenever the package is upgraded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants