Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duration codes used in sequence don't emulate accurately. #15

Open
ChrisBlueStone opened this issue Jan 10, 2022 · 1 comment
Open

Duration codes used in sequence don't emulate accurately. #15

ChrisBlueStone opened this issue Jan 10, 2022 · 1 comment

Comments

@ChrisBlueStone
Copy link
Collaborator

ChrisBlueStone commented Jan 10, 2022 •
edited
Loading

Duration codes that are used in succession playback different in-game vs in ebmused. I.e. [30 7F] [50] will not set the duration to [50] as it does in ebmused, but instead EB will play a note with duration/style [30 7F] that would be note [D0] (0x50 + 0x80) if the valid note ranges extended that far. Either ebmused should emulate these notes accurately, or somehow prevent/discourage users from using multiple duration/style codes in succession.

durationbug.zip
@livvy94
Copy link
Contributor

livvy94 commented Feb 17, 2022

I'm leaning more towards discouraging users from doing this with an error dialogue, it's bad form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChrisBlueStone @livvy94