Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show survey_years when fill_gaps = TRUE ? #191

Open
Aeilert opened this issue Feb 2, 2022 · 5 comments
Open

Show survey_years when fill_gaps = TRUE ? #191

Aeilert opened this issue Feb 2, 2022 · 5 comments
Labels
Backlog Placeholder for issues moved to backlog

Comments

@Aeilert
Copy link

Aeilert commented Feb 2, 2022

Original issue raised by @danielmahler : "Is there a way to show the survey_years that is used in the interpolation? I think not, but if there is, then that would be incredibly helpful to users (and for us to calculate coverage)".

This is technically possible, but has also has some technical downsides;

  • It is preferable that the /pip response w/ and wo/ fill_gaps is identical in terms of columns and col types. This wouldn't work that well for survey_year since it is numeric when fill_gaps = FALSE, but would need to be character if it is a string of collapsed survey years (e.g. "2000|2005").
  • All other collapsed columns are also set to NA. Not sure we should make an exception for survey_year.

On the hand maybe this would be so beneficial for users that we should come up with a solutions. Any thoughts @tonyfujs?

We won't need this to calculate coverage however, since that will happen at the pipeline stage (using the full refyear table)
@tonyfujs
Copy link
Contributor

tonyfujs commented Feb 2, 2022

Thanks @Aeilert
My initial thought is not to mess up with the response. A solution that could probably satisfy everyone is to have another endpoint that provides that information (we may already have it) and can easily be merged with the main response. What do you think?

@Aeilert
Copy link
Author

Aeilert commented Feb 2, 2022

Thanks @tonyfujs

Yep. I like the new endpoint idea!

@randrescastaneda , @danielmahler: What do you think?

@Aeilert Aeilert mentioned this issue Feb 2, 2022
Closed
@danielmahler
Copy link

danielmahler commented Feb 2, 2022 via email

@Aeilert
Copy link
Author

Aeilert commented Feb 3, 2022

That could work. What would that imply in practice if I use, say, the Stata ado?

@danielmahler: Good question. So I think the easiest would be to just have a new command / function hat pulls that information. I.e in addition to pip you have a set of other methods. E.g for the R wrapper I'm imagining functions like pipr::pip() (main response from /pip endpoint), pipr::aux() (select your AUX table of choice) and maybe a few other functions. The information on survey years used for interpolation could either be in a new "aux" table or have a completely separate function (e.g pipr::something_else)

@danielmahler
Copy link

danielmahler commented Feb 3, 2022 via email

@tonyfujs tonyfujs added Backlog Placeholder for issues moved to backlog and removed Backlog Placeholder for issues moved to backlog Priority: 3-Medium Type: 2-Enhancement New feature or request labels May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Backlog Placeholder for issues moved to backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tonyfujs @Aeilert @danielmahler