Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic when "API Constants" uses alias instead of value #19

Open
TimDiekmann opened this issue Mar 10, 2018 · 1 comment
Open

panic when "API Constants" uses alias instead of value #19

TimDiekmann opened this issue Mar 10, 2018 · 1 comment

Comments

@TimDiekmann
Copy link

TimDiekmann commented Mar 10, 2018

The parser fails, if the vk.xml has an enum without value-attribute. It can't parse the alias. Happens in vk.xml v1.1.70

Edit: You never handle any alias-names

Edit: To be honest, your error handling is horrible and you should consider using rustfmt

@Osspial
Copy link
Owner

Osspial commented Mar 11, 2018

It looks like aliases were only just added in 1.1.70, so there wasn't much consideration for them when this library was originally written. I feel like, for now, the simplest solution would be to add code that ignores alias-only variants, to get 1.1.70 compiling in lieu of more comprehensive alias handling.

Also, I'm pretty sure I used panics exclusively because making custom error types is a pain, the ? operator wasn't stable, and this is intended for use in build scripts where there isn't much you can do to recover from an error of this type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants