Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

DApp modal does not go away after saving profile #571

Closed
franckc opened this issue Sep 24, 2018 · 2 comments
Closed

DApp modal does not go away after saving profile #571

franckc opened this issue Sep 24, 2018 · 2 comments
Assignees
Labels

Comments

@franckc
Copy link
Contributor

franckc commented Sep 24, 2018

From @micahalcorn: Transaction goes thru on blockchain but DApp doesn't know. So it sticks on "Confirm transaction Press "Submit" in MetaMask window" and the form doesn't reset. I suspect that some previously-available return value is no longer surfacing.

Pull Requests solving issue:

@sparrowDom
Copy link
Member

The cause of the delay seems to be because transactions takes more time to mined on Rinkeby network comparing to localhost. I got transaction approved (running on Rinkeby) after 40 seconds of waiting:
screenshot 2018-09-25 11 22 14

I have seen some discussion on Discord between @jordajm @micahalcorn and @nick about the idea to change the waiting for transaction hash instead of transaction receipt.

This proposal Pull Request changes the DApp to wait for transactionHash when deploying a profile.

@micahalcorn
Copy link
Member

Resolved by #577

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants