You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 14, 2020. It is now read-only.
Currently we create the sample listing via a script that runs as part of the truffle migration steps. The script calls directly the marketplace contract method createListing as opposed to using origin-js. This causes issue since some logic in origin-js runs as part of listing creation to properly set the deposit amount for example before calling the marketplace contract.
It would be better to move sample listing creation to a separate script that would get executed as part of the scripts/build.js build script.
The text was updated successfully, but these errors were encountered:
franckc
changed the title
Move sample listing creation our of truffle migration scripts
Move sample listing creation out of truffle migration scripts
Sep 18, 2018
In order to instantiate an Origin object, I need to point to either the origin-js npm or at a locally compiled version of it. But none of those exist yet when build.js runs. I also tried to point to dist/index.js but similarily that fails since webpack compiles that file as part of build.js running...
The upload to IPFS of b64 encoded image data fails unless I make changes to the IpfsService. saveDataURIAsFile method (see Optimize method saveDataURIAsFile #511). I have tested it on Node.js and Chrome browser installed on my envionment but this might be a risky change to put in without more validation on different type of browsers...
Overall I'm inclined to do the following:
For our Testnet release, disable sample listing creation on Rinkeby. We can create those manually if needed.
Continue looking at options for automatically creating sample listings when origin-js container gets started...
Currently we create the sample listing via a script that runs as part of the truffle migration steps. The script calls directly the marketplace contract method createListing as opposed to using origin-js. This causes issue since some logic in origin-js runs as part of listing creation to properly set the deposit amount for example before calling the marketplace contract.
It would be better to move sample listing creation to a separate script that would get executed as part of the scripts/build.js build script.
The text was updated successfully, but these errors were encountered: