Cannot use recaptcha shape in razor views after latest changes

[giannik]

Using the new shape approach to enabling a recaptcha on a razor page does not work in the latest version. I added the following Shape tag helper in one of my views :

<shape type="ReCaptcha" language="@Orchard.CultureName()"/>

and got into an endless loop error until all threads were exhausted.

Changes described here :
https://github.com/OrchardCMS/OrchardCore/blob/main/src/docs/releases/3.0.0.md
Related pr #17229

[giannik]

there is a duplicate tag declaration "captcha" here :

OrchardCore/src/OrchardCore/OrchardCore.ReCaptcha.Core/TagHelpers/ReCaptchaTagHelper.cs

Line 8 in adda289

[HtmlTargetElement("captcha", Attributes = "language,onload", TagStructure = TagStructure.WithoutEndTag)]

is this on purpose ? @MikeAlhayek

[MikeAlhayek]

no. But is it causing any issues?

[giannik]

if i keep only one declaration the endless loop goes away but then it renders :

<captcha language="en-US">  
</captcha>

so it doesnt resolve the tag halper.

[github-actions]

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.