-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent usage of "Display Type" terminology #17366
Comments
If we have a shape type
To hide it from being displayed on
Did I misunderstand your request or is my assessment is invalid? |
@MikeAlhayek, I agree with the examples you provided. The typical display types are My confusion comes from this part of the documentation introduce in commit c5ed897: Specifically, in this line:
This might further highlight the issue: The "DisplayType" in Instead, it seems to the literal Line 13 in 0c5fb0e
Or the literal Line 270 in 0c5fb0e
I think this is mostly just a case of using the wrong terminology. The Or should we just replace: with: |
Hummm, TextField_Summary is not consistent with what I expected. Did you actually try it? Is the document you referenced |
@MikeAlhayek, the issue is specifically with the terminology in commit c5ed897, so it only comes into play when dealing with display modes. I agree that the documentation is correct when not using a display mode, as in your example. I have tried this and can confirm that including the display type in the shape type does not work, so the documentation should be corrected. The documentation states:
As you said, The documentation also provides this pattern shape type: Using the example in the documentation, I add a "heading" display mode to the TextField. I have a content part Using the documented pattern, this would mean the shape type should be This is incorrect. The correct shape type is The issue is the pattern in the documentation ( It would be more accurate to use this pattern in the documentation: I can submit a PR for that change, but that doesn't capture that either |
Please submit a PR to correct the docs. Just be sure to test out the updated docs so that the example you'll provide will be valid |
We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues). This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here. |
Describe the bug
Typically, "Display Type" refers to the render context (e.g. Detail, Summary, Admin, SummaryAdmin). See:
OrchardCore/src/docs/reference/glossary/README.md
Line 31 in 1814599
However, the Placement documentation uses "Display Type" to mean, seemingly, two different things:
OrchardCore/src/docs/reference/modules/Placement/README.md
Line 33 in 1814599
Orchard Core version
commit c5ed897 / #17333
To Reproduce
N/A
Expected behavior
Are both of these really "Display Types" or should the Display/Edit use different terminology?
Logs and screenshots
The text was updated successfully, but these errors were encountered: