Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings are blank in the Admin UI when loaded from the Configuration #17299

Open
jbytes1027 opened this issue Jan 4, 2025 · 4 comments
Open
Milestone

Comments

@jbytes1027
Copy link
Contributor

Problem

Settings are blank in Admin UI when loaded from the Configuration (e.g. appsettings.json):

Screenshot 2025-01-04 at 14-29-59 Demo Site - Settings

This makes you think these values are not set, when in-fact they are.

Note: The example is for the Microsoft module but I assume it's true for all the other modules that allow loading from the Configuration.

Proposed solution

Show in the UI that the setting was already set by the config. For example make the input non-editable and set the text to the valued loaded from the environment and with a message explaining the value was overridden by the Configuration. Or a simpler solution would just be a banner saying "some settings are overridden by Configuration" or something.

Other solutions

  1. Remove loading from Configuration. Would reduce complexity, confusion, and project scope. Discussion and decision not to in configuration stored in appsettings.json is not taken into account #15310.
  2. Load Configuration into UI and/or DB as default values. Would be confusing and updating them would override hidden DB valued the user never knew about.
@hishamco
Copy link
Member

hishamco commented Jan 4, 2025

I think something goes wrong here, it should work. Are you sure that you setup the settings in appsettings.json properly?

@jbytes1027
Copy link
Contributor Author

I didn't actually fully set up Entra ID but with a debugger I can see the values are loaded in AzureADOptionsConfiguration.Configure and applied to the options variable without the warning.

An erroneous warning is logged, but that's part of #17299.

@Piedone
Copy link
Member

Piedone commented Jan 5, 2025

Showing a banner that these settings are loaded from external configuration would be a good solution, because that can be overridden if you set the config from the admin. I think we have examples of such banners for other features.

@sebastienros sebastienros added this to the 3.x milestone Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants