Improve Liquid Culture accessor #16956
Open
+56
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienros
reviewed
Nov 5, 2024
src/OrchardCore/OrchardCore.DisplayManagement.Liquid/LiquidCultureAccessor.cs
Show resolved
Hide resolved
|
|
||
| public override string ToStringValue() => _culture.Name; | ||
|
|
||
| public override void WriteTo(TextWriter writer, TextEncoder encoder, CultureInfo cultureInfo) |
There was a problem hiding this comment.
I wrote another PR while you writing comments :)
|
|
||
| public override bool Equals(FluidValue other) | ||
| { | ||
| throw new NotImplementedException(); |
There was a problem hiding this comment.
Maybe compare string representation with culture code? In case someone does Culture == 'en-US'
There was a problem hiding this comment.
Please test it though, not sure when Equals is invoked
There was a problem hiding this comment.
Please test it though, not sure when Equals is invoked
I can write a unit test, but I'm not sure when it called either :)
src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Values/CultureValue.cs
Outdated
Show resolved
Hide resolved
…ltureValue.cs Co-authored-by: Sébastien Ros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16957