Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate IContentDefinitionEventHandler to the new IContentDefinitionHandler #16926

Open
MikeAlhayek opened this issue Oct 24, 2024 · 1 comment
Milestone

Comments

@MikeAlhayek
Copy link
Member

Currently, the IContentDefinitionEventHandler interface introduces events that are triggered by the ContentDefinitionService. However, this service is primarily intended for use by controllers, and while it’s acceptable to retain it "if needed," it should not be responsible for triggering event handlers.

To improve consistency and ensure proper separation of concerns, all content definition events should be triggered by the ContentDefinitionManager, which is better suited for managing content definitions. Moving forward, the ContentDefinitionManager should be responsible for invoking events and continue using the IContentDefinitionHandler interface.

To streamline this process, the IContentDefinitionEventHandler interface and its associated events should be marked as obsolete. This approach ensures that event handling is centralized in the ContentDefinitionManager, leading to better maintainability and cleaner architecture.

@MikeAlhayek MikeAlhayek added this to the 3.0 milestone Oct 24, 2024
Copy link
Contributor

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant