Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove any default implementations from interfaces #16905

Open
MikeAlhayek opened this issue Oct 17, 2024 · 3 comments
Open

Remove any default implementations from interfaces #16905

MikeAlhayek opened this issue Oct 17, 2024 · 3 comments
Milestone

Comments

@MikeAlhayek
Copy link
Member

Sometimes we add a default implementation in interfaces to avoid breaking change. With a major release, we should remove the default implementations and document this as a break change. Here are some of the interfaces that should be modified:

  • ILoginFormEvent
@MikeAlhayek MikeAlhayek added this to the 3.0 milestone Oct 17, 2024
Copy link
Contributor

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

@hishamco
Copy link
Member

FYI there is an interface that has a default implementation for a reason, so we need to remove those who have an implementation to avoid the breaking change at that time

@MikeAlhayek
Copy link
Member Author

I know there is a reason. The reason is started I my issue. In v3 we need to remove the default implementation from the interface and introduce a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants