Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a logic Error on Update Api (OCC-295) #495

Closed
infofromca opened this issue Sep 12, 2024 · 0 comments · Fixed by #496
Closed

There is a logic Error on Update Api (OCC-295) #495

infofromca opened this issue Sep 12, 2024 · 0 comments · Fixed by #496
Labels
bug Something isn't working

Comments

@infofromca
Copy link
Contributor

infofromca commented Sep 12, 2024

Describe the bug

Maybe the following event will overrise the previous result

To Reproduce

Steps to reproduce the behavior:

  1. Go to '.public async Task UpdateAsync(ShoppingCartUpdateModel cart, string token, string shoppingCartId = null)..'
    of ShoppingCartService class
  2. See error
    Maybe the following event (if it is true) will overrise the previous result(false)

Expected behavior

if found isValid = false; should break; otherwise, the following event will overrise the previous result.

Jira issue

@infofromca infofromca added the bug Something isn't working label Sep 12, 2024
@github-actions github-actions bot changed the title There is a logic Error on Update Api There is a logic Error on Update Api (OCC-295) Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant