Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to latest OC preview in a separate branch to test System.Text.Json (OCC-245) #442

Open
sarahelsaig opened this issue May 4, 2024 · 3 comments
Open

Upgrade to latest OC preview in a separate branch to test System.Text.Json (OCC-245) #442

sarahelsaig opened this issue May 4, 2024 · 3 comments
Assignees
@sarahelsaig
Labels
enhancement New feature or request technical debt Necessary but not urgent code cleanup or reorganization

Comments

@sarahelsaig
Copy link
Contributor

sarahelsaig commented May 4, 2024 •
edited by github-actions bot
Loading

Followup to Lombiq/Open-Source-Orchard-Core-Extensions#692

  • Open a task/system-text-json-migration branch from main and start your issue branch from there. After this issue is done, we won't yet merge this to main, waiting for that for OC v2.0.
  • Upgrade all OC and Lombiq packages to the appropriate 2.0 preview versions.
  • Remove all Newtonsoft.Json converters (Legacy*Converter classes), only the STJ versions should remain. If there are any types with only Newtonsoft converters, implement the missing STJ version.
  • Fix any other bugs.
  • For every general OC issue we find, open an OC issue.

Jira issue
@sarahelsaig sarahelsaig added enhancement New feature or request technical debt Necessary but not urgent code cleanup or reorganization labels May 4, 2024
@github-actions github-actions bot changed the title Upgrade to latest OC preview to test System.Text.Json Upgrade to latest OC preview to test System.Text.Json (OCC-245) May 4, 2024
@sarahelsaig sarahelsaig changed the title Upgrade to latest OC preview to test System.Text.Json (OCC-245) Upgrade to latest OC preview in a separate branch to test System.Text.Json (OCC-245) May 4, 2024
@Piedone
Copy link
Member

Piedone commented May 4, 2024

FYI this too @MikeAlhayek.

@Piedone Piedone mentioned this issue May 16, 2024
Open
@github-actions github-actions bot mentioned this issue May 30, 2024
Merged
@Piedone Piedone mentioned this issue Jun 5, 2024
Open
4 tasks
@Piedone
Copy link
Member

Piedone commented Jun 10, 2024

What's up here, @sarahelsaig?

@sarahelsaig
Copy link
Contributor Author

I'm struggling with CloudSmitch package restores failing only in GHA runs (they work in local). Turns out this is not limited to NuGet publishing, for example normal build fails in NEST-536 as well (for example here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarahelsaig sarahelsaig

Labels
enhancement New feature or request technical debt Necessary but not urgent code cleanup or reorganization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Piedone @sarahelsaig