Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require login to browse the products in the autosetup recipe (OCC-190) #349

Closed
agriffard opened this issue Sep 16, 2023 · 2 comments · Fixed by #360
Closed

Don't require login to browse the products in the autosetup recipe (OCC-190) #349

agriffard opened this issue Sep 16, 2023 · 2 comments · Fixed by #360
Assignees

Comments

@agriffard
Copy link
Member

agriffard commented Sep 16, 2023

If you are logged in, the home url redirects to the login.
You should be able to access it anonymously.

This is currently a Page content type that only has a TitlePart and an AutoroutePart.

You have to provide some ways to list products (Widgets on Home Layer or LiquidPart with query).

Jira issue

@github-actions github-actions bot changed the title Homepage Homepage (OCC-190) Sep 16, 2023
@agriffard
Copy link
Member Author

I guess you started a PR to use a ListPart here: #346.

@sarahelsaig sarahelsaig changed the title Homepage (OCC-190) Don't require login to browse the products in the autosetup recipe (OCC-190) Sep 28, 2023
@sarahelsaig
Copy link
Contributor

Since the listing on the home page has already been handled in #343 (OCC-185), what's left to do here is to add permissions to the development setup recipe. It's possibly enough to just move the roles step from OrchardCore.Commerce.Development.Tests.Setup.recipe.json to OrchardCore.Commerce.Development.Setup.recipe.json. I've updated the title accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants