Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check 'Maximum Order Quantity' update on Cart (OCC-183) #340

Closed
agriffard opened this issue Sep 14, 2023 · 5 comments · Fixed by #353
Closed

Check 'Maximum Order Quantity' update on Cart (OCC-183) #340

agriffard opened this issue Sep 14, 2023 · 5 comments · Fixed by #353
Assignees

Comments

@agriffard
Copy link
Member

agriffard commented Sep 14, 2023

When I want to add a discounted product that has a 'Maximum Order Quantity' = 2 an set 3 items, I get the expected message:
The checkout quantity for Test Discounted Product is more than the maximum allowed.

But when I am on the cart page and change the number of items to a number > 3, there is no such message so I could order more than 'Maximum Order Quantity' limit that is set.

Jira issue

@github-actions github-actions bot changed the title Check 'Maximum Order Quantity' update on Cart Check 'Maximum Order Quantity' update on Cart (OCC-183) Sep 14, 2023
@sarahelsaig
Copy link
Contributor

Sorry, I wasn't able to reproduce this. Can you send a step-by-step or screen recording?

@porgabi
Copy link
Contributor

porgabi commented Sep 18, 2023

Not OP, but I could reproduce by simply adding 1 Test Discounted Product to cart and then, within the cart, updating its quantity to 5, which shouldn't be possible as the max order quantity is set to 2.

image

@sarahelsaig
Copy link
Contributor

That won't actually allow you to order more than the maximum though.

@porgabi
Copy link
Contributor

porgabi commented Sep 18, 2023

I haven't encountered any errors while checking out with these parameters, so it seems possible:

firefox_sA8Yo2bSF6.mp4

@porgabi
Copy link
Contributor

porgabi commented Sep 18, 2023

Additionally, if you check out with a quantity higher than the available inventory's value with back ordering disabled, you get a big friendly exception.

image

I think it just needs inventory checking added for the method that handles cart updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants