Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable order Id pattern (OCC-104) #214

Open
wAsnk opened this issue Oct 17, 2022 · 7 comments
Open

Customizable order Id pattern (OCC-104) #214

wAsnk opened this issue Oct 17, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@wAsnk
Copy link
Contributor

wAsnk commented Oct 17, 2022

Is your feature request related to a problem? Please describe

While I see the point of using GUID as the order ID for being it unique, it loses the essential for easy identification during user <-> webshop owner communication because it is too random and long, mostly not humanly readable.

Describe the solution you'd like

Some sort of customization for order ID. There could be a template (pattern) that would be followed by the ID generator. E.g. date, time, random number within X digits. Really good example.

Jira issue

@wAsnk wAsnk added the enhancement New feature or request label Oct 17, 2022
@github-actions github-actions bot changed the title Customizable order Id pattern Customizable order Id pattern (OCC-104) Oct 17, 2022
@DemeSzabolcs
Copy link
Contributor

I'm not sure how customizable it should be. A simple solution could be to create a site setting, where you can switch between predefined ID styles (like GUID and the thing you suggested).

@wAsnk
Copy link
Contributor Author

wAsnk commented Oct 20, 2022

This is something more advanced than the other suggestion Dávid had about having the Content Id as the Order Id.

@sarahelsaig
Copy link
Contributor

We could create multiple order ID generator providers. Then add a content type setting for Order where you can select which ID generator to use, and optionally to provide a string.Format formatter string in a text input. It can be made really fancy and expandable, e.g. if the consumer wants to ask their invoicing/accounting system for an ID instead of generating one locally.

I think we won't need this much until we start implementing some kind of invoicing support.

@wAsnk
Copy link
Contributor Author

wAsnk commented Oct 20, 2022

Yeah, that was my idea too, to have multiple providers etc...

But for now I would like to have the settings for Content Id over GUID, if that's okay.

@sarahelsaig
Copy link
Contributor

sarahelsaig commented Oct 20, 2022

Where do you actually need that? I figured it's only used in the email and Order display page so you can just use ContentItem.Id from liquid.

@wAsnk
Copy link
Contributor Author

wAsnk commented Oct 20, 2022

It's needed for the webshop admins/cashiers/whatever to identify an order by a customer call or contact or whatever. It's not so simple with that generated long Id. As you usually do when you order something and you want to pick it up at the store, you usually tell the cashiers an X digit number and with that they identify your order.

@dpomt
Copy link

dpomt commented Dec 29, 2023

Same requirement as @wAsnk mentioned: an orderid that is easier to read/recognize, e.g. just an incremented number starting from a predefined value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants