UtcDateTime expect date kind Utc but it is Unspecified

[MatteoPiovanelli-Laser]

This kind of exception is thrown by somequery on the dev branch.

I've tracked it down, and it seems related to

Orchard/src/Orchard/Data/Conventions/UtcDateTimeConvention.cs

Line 13 in ca86ec9

public class UtcDateTimeConvention : IPropertyConvention, IPropertyConventionAcceptance {

(basically, if a property in a record is a DateTime and its name ends with "Utc", in NHibernate the type would be DateTimeType, rather than DateTimeType) and the fact that nHibernate version 5.x (that is in dev since January) enforces that type more strongly.

I have already tested locally a fix in a NHibernateExpressionVisitor that would allow Orchard to handle that cleanly and seems to work for all cases (all that I've been able to test).

I was wondering whether @sebastienros remembers if that convention there is important, because I have a feeling that removing it would also fix this issue.

[MatteoPiovanelli-Laser]

Correction: removing the convention doesn't seem to work at all. I'm not sure why and can't investigate it right now.