Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] app crash on color token page opening #215

Closed
1 task done
B3nz01d opened this issue Oct 19, 2024 · 2 comments · Fixed by #217
Closed
1 task done

[Bug] app crash on color token page opening #215

B3nz01d opened this issue Oct 19, 2024 · 2 comments · Fixed by #217
Assignees
@pylapp
Labels
🐞 bug Something isn't working 📱 demo app Update of the Demo App

Comments

@B3nz01d
Copy link
Collaborator

B3nz01d commented Oct 19, 2024

Prerequisites

Your test device

iPhone 14 Pro

OS Version

17.6.1

App version

V0.4.0 1729285509

App orientation

Portrait

Device language

US

App language

EN

Describe the issue

The app crashed when I opened the color token page

Expected Behavior

Not to crash obviously ;)

Accessibility settings

None
@B3nz01d B3nz01d added 🐞 bug Something isn't working 🔍 triage A new issue that needs to be treated labels Oct 19, 2024
@pylapp
Copy link
Member

pylapp commented Oct 19, 2024 •
edited
Loading

Maybe this is because a color semantic token has not been defined, but only declared, due to the fact the design system has holes in their definitions. The token must be found and not integrated in the demo app.

This issue appeared maybe because the reviewer of the related PR did not run the app and trusted the developer who only fixed code without further testing.

For the next release we will add UI unit tests to check for each page of the app does not crash ; then we will be able to prevent this issue by detecting earlier tokens without implementations.

This will be fixed in an hotfix or bugfix release v0.4.1

@pylapp pylapp moved this from Triage to Todo in [OUDS] Project Oct 19, 2024
@pylapp pylapp assigned pylapp and unassigned ludovic35 Oct 19, 2024
@pylapp pylapp added 📱 demo app Update of the Demo App and removed 🔍 triage A new issue that needs to be treated labels Oct 19, 2024
@pylapp pylapp mentioned this issue Oct 19, 2024
Open
@pylapp
Copy link
Member

pylapp commented Oct 19, 2024

See #216

@ludovic35 ludovic35 linked a pull request Oct 21, 2024 that will close this issue
[#215] App crash on color token page opening #217
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in [OUDS] Project Oct 21, 2024
@pylapp pylapp mentioned this issue Oct 21, 2024
Merged
pylapp added a commit that referenced this issue Oct 21, 2024
@pylapp @ludovic35
Release 0.4.1 (#220)
29124a0 
Release of version 0.4.1
See below the full CHANGELOG details.

Fixed
- [Demoapp] App crash on color token page opening ([#215](#215))

Co-authored-by: Ludovic Pinel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pylapp pylapp

Labels
🐞 bug Something isn't working 📱 demo app Update of the Demo App
Projects
[OUDS] Project
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#215] App crash on color token page opening Orange-OpenSource/ouds-ios
4 participants
@pylapp @ludovic35 @Tayebsed93 @B3nz01d