Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error using boosted 4 tooltip in an Angular project #276

Open
3 tasks done
jacques-lebourgeois opened this issue Jun 17, 2024 · 8 comments · May be fixed by #407
Open
3 tasks done

Error using boosted 4 tooltip in an Angular project #276

jacques-lebourgeois opened this issue Jun 17, 2024 · 8 comments · May be fixed by #407
Assignees
Labels
bug Something isn't working

Comments

@jacques-lebourgeois
Copy link
Member

jacques-lebourgeois commented Jun 17, 2024

Prerequisites

Describe the issue

Using tooltip managed by ODS Charts with Boosted 4 renderer fails

    // Register the externalization of the tooltip/popup
    this.themeManager.externalizePopover(
      {},
      ODSCharts.ODSChartsPopoverManagers.BOOSTED4
    );

Reduced test cases

we got the error console

ods-charts.js:2782 ReferenceError: boosted is not defined
    at BOOSTED4_Definition._getOrCreatePopupInstance (ods-charts.js:2229:1)

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome

What version of ODS Charts are you using?

v0.1.0-alpha.9

@jacques-lebourgeois jacques-lebourgeois added the bug Something isn't working label Jun 17, 2024
@vogloblinsky
Copy link

+1

@jacques-lebourgeois
Copy link
Member Author

I'm closing this bug as it no longer seems relevant. It has probably been solved at Docs: isolate charts in <iframe>s #173

@vogloblinsky
Copy link

Sorry but i think an explanation of Boosted dependency in the documentation is missing.
Just installed last week ODS in my project, and without Boosted, i had to disable externalizePopover to make it works

@jacques-lebourgeois
Copy link
Member Author

Sorry but i think an explanation of Boosted dependency in the documentation is missing. Just installed last week ODS in my project, and without Boosted, i had to disable externalizePopover to make it works

You're absolutely right, the documentaion is largely perfectible.

Just to be sure, do you use Boosted or not on your project?

Because the library also works without Boosted.

You can use :

  • for graph layout
    • ODS Charts only
    • Boosted 5
    • Boosted 4
  • to display a popover or tooltip :
    • Apache Echarts rendering customized for ODS by ODS Charts
    • Boosted 4 or 5 rendering

If your problem came from this misunderstanding, the bug is probably more a bug of incomplete documentation.

Let me know,

Thks

@vogloblinsky
Copy link

I am in a Nuxt project, with Boosted loaded by a Nuxt plugin, but it seems not injected directly in the page, boosted main global variable is not accessible.

ReferenceError: boosted is not defined at BOOSTED5_Definition._getOrCreatePopupInstance (ods-charts.js?v=70f8a3e3:2293:80)

@jacques-lebourgeois
Copy link
Member Author

So, there is probably a bug, you are right.

In the meantime, you can still use ODS Charts popovers and tooltips by using Apache ECharts and ODS Charts rendering.

To do this, you need to specify the renderer ODSChartsPopoverManagers.NONE as the second parameter of the externalizePopover

themeManager.externalizePopover({ }, 
  ODSCharts.ODSChartsPopoverManagers.NONE
);

Unfortunately, the documentation doesn't make this very clear. But you can find this setting in the example pages of the online configurator by choosing "Apache ECharts rendrerer" as "Popover Renderer"

Image

@vogloblinsky
Copy link

Ok nice.
I think it should be mentionned in the main README. It is more clear here. In the API documentation it is also relevant, but the design is more visually cluttered.

@jacques-lebourgeois jacques-lebourgeois self-assigned this Nov 14, 2024
@jacques-lebourgeois jacques-lebourgeois linked a pull request Nov 15, 2024 that will close this issue
9 tasks
@jacques-lebourgeois
Copy link
Member Author

NB: the bug is the sme with Boosted 5

ReferenceError: boosted is not defined
    at BOOSTED5_Definition._getOrCreatePopupInstance (ods-chart-popover-definitions.ts:119:1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants