Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Enhancements #15

Open
hpmax opened this issue May 31, 2020 · 1 comment
Open

Potential Enhancements #15

hpmax opened this issue May 31, 2020 · 1 comment

Comments

@hpmax
Copy link
Contributor

hpmax commented May 31, 2020

I have three potential enhancements I'd like to offer (I put in a pull request on one):

  1. The current algorithm for calculating voltage simply linearly scales the output of the ADS1110. After looking into this more, this is not accurate, there should be a scale and offset term. I implemented this in my pull request and added a second term to the config file. If the term is missing, it will assume 0, which is the same current behavior.

  2. Is there any reason why second order MS5611 compensation isn't on by default, and/or why it isn't turned on in the config file and only from the command line?

  3. I have added DS18B20 temp sensor support and it appears to work well. My code only uses the SKIP ROM command, which means it can only address one thing on the 1-wire bus. I have code to handle the MATCH ROM but it hasn't been tested. Can anyone see a good reason why support for multiple 1-wire devices is needed?

@mihu-ov
Copy link
Member

mihu-ov commented Jul 31, 2020

  1. Thank you! It should have been done like that from the very beginning but unfortunately never was.
  2. Probably to avoid additional complexity (read: possible errors)
  3. Most people would not use more than a single temperature sensor on 1W bus. But from experience with all us tinkerers somebody will require additional devices on 1W. Go step by step, include code for a single 1W device now and improve later?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants