You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have three potential enhancements I'd like to offer (I put in a pull request on one):
The current algorithm for calculating voltage simply linearly scales the output of the ADS1110. After looking into this more, this is not accurate, there should be a scale and offset term. I implemented this in my pull request and added a second term to the config file. If the term is missing, it will assume 0, which is the same current behavior.
Is there any reason why second order MS5611 compensation isn't on by default, and/or why it isn't turned on in the config file and only from the command line?
I have added DS18B20 temp sensor support and it appears to work well. My code only uses the SKIP ROM command, which means it can only address one thing on the 1-wire bus. I have code to handle the MATCH ROM but it hasn't been tested. Can anyone see a good reason why support for multiple 1-wire devices is needed?
The text was updated successfully, but these errors were encountered:
Thank you! It should have been done like that from the very beginning but unfortunately never was.
Probably to avoid additional complexity (read: possible errors)
Most people would not use more than a single temperature sensor on 1W bus. But from experience with all us tinkerers somebody will require additional devices on 1W. Go step by step, include code for a single 1W device now and improve later?
I have three potential enhancements I'd like to offer (I put in a pull request on one):
The current algorithm for calculating voltage simply linearly scales the output of the ADS1110. After looking into this more, this is not accurate, there should be a scale and offset term. I implemented this in my pull request and added a second term to the config file. If the term is missing, it will assume 0, which is the same current behavior.
Is there any reason why second order MS5611 compensation isn't on by default, and/or why it isn't turned on in the config file and only from the command line?
I have added DS18B20 temp sensor support and it appears to work well. My code only uses the SKIP ROM command, which means it can only address one thing on the 1-wire bus. I have code to handle the MATCH ROM but it hasn't been tested. Can anyone see a good reason why support for multiple 1-wire devices is needed?
The text was updated successfully, but these errors were encountered: