Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Governor redundant overrides #218

Open
frangio opened this issue Jan 12, 2023 · 0 comments
Open

Governor redundant overrides #218

frangio opened this issue Jan 12, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@frangio
Copy link
Contributor

frangio commented Jan 12, 2023

There seem to be some redundant overrides in generated Governor code as seen in OpenZeppelin/openzeppelin-contracts#3948. At least the quorum override may not be necessary in some or all of the combinations.
@ericglau ericglau added the good first issue Good for newcomers label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frangio @ericglau