Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.6 Critical Update - Catching Exceptions from OZW (python-openzwave) #177

Open
Fishwaldo opened this issue May 8, 2019 · 1 comment
Open

Comments

@Fishwaldo
Copy link
Member

Fishwaldo commented May 8, 2019

As per the OZW 1.6 Release Notes, Exceptions are now used throughout OZW

Any calls to any OZW Methods (in any of the Classes, such as Manager, Options etc) now may raise a exception on errors.

Need to wrap these calls with a try...catch block and determine the best way to raise the error to the application.

The List of possible exceptions is in OZWException.h but expect it to potentially grow.

This is a potentially breaking change in OZW 1.6 Many applications that have attempted to migrate from 1.4 to 1.6 are getting caught out by this.

Ideally, exceptions should not happen at all, but as per the best guess I can make, applications, or wrappers are creating their own copies of ValueID's and passing them to OZW. Only OZW should create a ValueID, and applications/wrappers store the ValueID's as they are announced in the Notification ValueAdded Callback.

@kdschlosser
Copy link
Contributor

OK I just went through and added exception catching on all calls made to openzwave.

I am going to let the tests run and see how goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants