Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim-to-fill time warp effects appear as the wrong type #2

Open
jminor opened this issue Dec 10, 2024 · 0 comments · May be fixed by OpenTimelineIO/otio-aaf-adapter#54
Open

Trim-to-fill time warp effects appear as the wrong type #2

jminor opened this issue Dec 10, 2024 · 0 comments · May be fixed by OpenTimelineIO/otio-aaf-adapter#54

Comments

@jminor
Copy link
Owner

jminor commented Dec 10, 2024

In the test suite OTIO, there are several trim-to-fill time warp effects which are not represented correctly. Those effects were added using Avid Media Composer's "Trim to FIll" from the Effect Palette window. They show up in the OTIO as TimeEffects but they should be LinearTimeWarp effects with a time_scalar value. I believe this is a bug in the AAF to OTIO conversion adapter, which is missing support for keyframes in the position graph. If so, I'll make a bug report there and link it here.

  • Linear time warps trim-to-fill
    • Trim-to-fill 99 frames into 100 (BUG: TimeEffect should be LinearTimeWarp)
    • Trim-to-fill 90 frames into 100 (BUG: TimeEffect should be LinearTimeWarp)
    • Trim-to-fill 50 frames into 100 (BUG: TimeEffect should be LinearTimeWarp)
    • Trim-to-fill 33 frames into 100 (BUG: TimeEffect should be LinearTimeWarp)
    • Trim-to-fill 5 frames into 100 (BUG: TimeEffect should be LinearTimeWarp)
    • Trim-to-fill 100 frames into 99 (BUG: TimeEffect should be LinearTimeWarp)
    • Trim-to-fill 100 frames into 50 (BUG: TimeEffect should be LinearTimeWarp)
    • Trim-to-fill 100 frames into 33 (BUG: TimeEffect should be LinearTimeWarp)
    • Trim-to-fill 100 frames into 10 (BUG: TimeEffect should be LinearTimeWarp)
    • Trim-to-fill 100 frames into 9 (BUG: TimeEffect should be LinearTimeWarp)
@jminor jminor changed the title Trim-to-fill time warp effects are not handled Trim-to-fill time warp effects appear as the wrong type Dec 10, 2024
@jminor jminor linked a pull request Dec 12, 2024 that will close this issue
Draft
This was referenced Dec 12, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Time warp fixes: Trim-to-fill jminor/otio-aaf-adapter
1 participant
@jminor