Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete account #65

Open
towerofnix opened this issue Jul 17, 2016 · 9 comments
Open

Delete account #65

towerofnix opened this issue Jul 17, 2016 · 9 comments

Comments

@towerofnix
Copy link
Member

Confirmation by email would be nice - and a no-activity requirement of a couple days or so like Scratch does might also be good. Input?

@bates64
Copy link
Contributor

bates64 commented Jul 17, 2016

But why would a user wish to delete their account other than also deleting their Scratch account?

I think it's worth, rather than email confirmation, asking for confirmation through Scratch comments. see below

@towerofnix
Copy link
Member Author

Speaking of which, if you delete your Scratch account, OS should probably also 'delete' your OS account.

However - after an account has been deleted, what should happen to resources and collections? I think Scratch admins can automatically delete all uploads/creations that users on Scratch have made, but when a user deletes their own account the projects don't get deleted.. For example the account eshinobip was deleted but its projects weren't.

All that really happens is the account's user page 404s.

(Being banned is different - your profile doesn't get deleted but you can't log on.)

(This info is really just guesstimations, I've never been banned or had an account deleted before! 📦)

@bates64
Copy link
Contributor

bates64 commented Jul 17, 2016

if you delete your Scratch account, OS should probably also 'delete' your OS account.

We'd have to check that on profile access, I assume?

@bates64
Copy link
Contributor

bates64 commented Jul 17, 2016

I think we should make deleting act like banning - just with confirmation from the acc owner rather than an admin - however resources are still visible (e.g. somebody links to it, we dont want dead links).

I feel like "deleted" user's projects on Scratch's side is accidental.

@MegaApuTurkUltra
Copy link
Member

I don't think it's worth deleting accounts - only hiding them, like we do with resources (speaking of that, I should add some more checks for deleted stuff 📦)

I don't think the ST ever truly deletes Scratch accounts either

@bates64
Copy link
Contributor

bates64 commented Jul 30, 2016

Sounds like the best method is to periodically check to see if a given Scratch user (that also has an OS account) returns HTTP 404.

Then we know that that Scratch user has been "deleted," and we can also "delete" (hide) said user too because to the end-user, they no longer exist.

@jamesd-uk
Copy link

Run a check every midnight on half the OS userbase, and the other half the next night?

@bates64
Copy link
Contributor

bates64 commented Jul 30, 2016

I'll assign @MegaApuTurkUltra to this - idk how cronjobs work

@MegaApuTurkUltra
Copy link
Member

node-cron is great and does all things 📦

@MegaApuTurkUltra MegaApuTurkUltra added this to the Initial Release milestone Aug 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants