Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: towed rolling stocks should really have a minimum value #9543

Open
eckter opened this issue Oct 31, 2024 · 4 comments · May be fixed by #10332
Open

editoast: towed rolling stocks should really have a minimum value #9543

eckter opened this issue Oct 31, 2024 · 4 comments · May be fixed by #10332
Assignees
@Wadjetz
Labels
area:editoast Work on Editoast Service kind:bug Something isn't working module:stdcm Short-Term DCM severity:minor Minor severity bug

Comments

@eckter
Copy link
Contributor

eckter commented Oct 31, 2024

What happened?

On the STDCM page, I tried a simulation with a train weighting 1t. That input is absurd, but the output was even more absurd: simulation failed, not enough traction.

Turns out, the RK4 integration doesn't really work out properly when the traction force is absurdly high compared to the weight. The first (2s) step goes up to 1500km/h. The second iteration starts at that speed and decelerates even faster. The average acceleration over 4 iterations end up negative => "not enough traction" to even go above 0km/h at the first step.

What did you expect to happen?

Anything from these options:

  1. A valid simulation where the train can start
  2. Input is considered invalid in the front-end
  3. A clear crash with a valid error message (even that would be better than "not enough traction")

How can we reproduce it (as minimally and precisely as possible)?

Send an STDCM request with a 1t train.

On which environments the bug occurs?

Local, Dev (SNCF)

On which browser the bug occurs?

Firefox

OSRD version (top right corner Account button > Informations)

a9261bc
@eckter eckter added the kind:bug Something isn't working label Oct 31, 2024
@eckter eckter changed the title front: convoy weight should really have a minimum value front: towed rolling stocks should really have a minimum value Oct 31, 2024
@eckter eckter added severity:minor Minor severity bug module:stdcm Short-Term DCM labels Oct 31, 2024
@maelysLeratRosso
Copy link

I created this enhancement today, so we should decide whether it is a bug or not.
I was told that it could not be done before this #9374

@eckter
Copy link
Contributor Author

eckter commented Oct 31, 2024

This one is a little different, it's not just about warning the user that they're making a mistake.

This is about protecting the back-end. An unreasonably low weight breaks the numerical integration in very weird ways.

In fact the test should probably be made somewhere in the back-end (possibly on top of front-end checks)

@bougue-pe bougue-pe added the area:front Work on Standard OSRD Interface modules label Nov 4, 2024
@SharglutDev
Copy link
Contributor

SharglutDev commented Jan 6, 2025 •
edited
Loading

Should be fixed with this PR

@Wadjetz
Copy link
Member

Wadjetz commented Jan 7, 2025

I will add the validation in the backend too

@Wadjetz Wadjetz changed the title front: towed rolling stocks should really have a minimum value editoast: towed rolling stocks should really have a minimum value Jan 8, 2025
@Wadjetz Wadjetz added area:editoast Work on Editoast Service and removed area:front Work on Standard OSRD Interface modules labels Jan 8, 2025
@Wadjetz Wadjetz linked a pull request Jan 13, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wadjetz Wadjetz

Labels
area:editoast Work on Editoast Service kind:bug Something isn't working module:stdcm Short-Term DCM severity:minor Minor severity bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

editoast: add consist params validation OpenRailAssociation/osrd
5 participants
@Wadjetz @eckter @SharglutDev @bougue-pe @maelysLeratRosso