Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

XPagesExtensionLibrary/extlib/lwp/product/runtime/eclipse/plugins/com.ibm.xsp.theme.bootstrap/src/com/ibm/xsp/theme/bootstrap/renderkit/html/extlib/layout/tree/ApplicationLinksRenderer.java #79

Open
guedeWebGate opened this issue Oct 20, 2016 · 1 comment

Comments

@guedeWebGate
Copy link
Member

What is the reason that makeSelectedActive return always false? Should it not return true, to match the Bootstrap Style Guide?

@briangleeson
Copy link

This appears to be a remnant of the original Bootstrap4XPages project, as you can see the same method returns false here: https://github.com/OpenNTF/Bootstrap4XPages/blob/master/eclipse/plugins/org.openntf.xsp.bootstrap/src/org/openntf/xsp/bootstrap/renderkit/html_extended/extlib/layout/tree/BootstrapApplicationLinksRenderer.java

Simple fix is to remove the method in ApplicationLinksRenderer and revert to using the superclass method. Only concern is any unexpected side effects, but it seems like it should be pretty clean.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants