Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OMPD] The LLVM OMPD ompd_get_task_frame() function has the wrong signature #56

Open
jdelsign opened this issue Feb 27, 2019 · 0 comments

Comments

@jdelsign
Copy link

The LLVM OMPD ompd_get_task_frame() function has the wrong signature (https://github.com/OpenMPToolsInterface/LLVM-openmp/blob/ompd-devices/libompd/src/ompd.h#L511):

    ompd_rc_t ompd_get_task_frame(
	ompd_task_handle_t *task_handle, /* IN: OpenMP task handle*/
	ompd_address_t *sp_exit,         /* OUT: next frame is user code */
	ompd_address_t *sp_reentry       /* OUT: previous frame is user code */
	);

The OpenMP 5.0 spec (and OpenMP omp-tools.h header) have:

    ompd_rc_t ompd_get_task_frame(ompd_task_handle_t *task_handle,
				  ompd_frame_info_t *exit_frame,
				  ompd_frame_info_t *enter_frame);

Specifically, the function is supposed to accept "ompd_frame_info_t" pointer for the exit and enter frames, but the LLVM OMPD library accepts "ompd_address_t" pointers.

@jdelsign jdelsign changed the title The LLVM OMPD ompd_get_task_frame() function has the wrong signature [OMPD] The LLVM OMPD ompd_get_task_frame() function has the wrong signature Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants