-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent duplicate App scripts and styles from being loaded #182
Comments
Proposing this for a new version |
Might consider solving #171 at the same time since its in the same code? |
Good call, thanks for linking the issues. |
I've only tested this in chrome, using the example container. Could use some help understanding how the jasmine tests are set up so I can try and add some for this. |
@bentaber I added one test to give you an idea of how they're setup. See here. The Jasmine tests rely on F2.min.js in both the headless and regular browser tests, so be sure to run |
After discussing the details of these changes, the F2 team sees them being released as a minor version change and not a patch. Therefore proposing version It's TBD whether this will get rolled into #142 or if #142 will become |
Quick update for those watching. We've been rolling in a few commits over the past two weeks (all listed here) in the
Finally, it is likely these updates (#184) will get merged into #142 for a final |
If you want to test out this |
We are looking at adding a map to track App script and style dependencies so that multiple versions of the same files are not downloaded by a Container. This enhancement has been discussed in #129 and others primarily revolving around v2 conversations. @bentaber
The text was updated successfully, but these errors were encountered: