Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate App scripts and styles from being loaded #182

Closed
markhealey opened this issue Oct 18, 2014 · 8 comments
Closed

Prevent duplicate App scripts and styles from being loaded #182

markhealey opened this issue Oct 18, 2014 · 8 comments

Comments

@markhealey
Copy link
Member

We are looking at adding a map to track App script and style dependencies so that multiple versions of the same files are not downloaded by a Container. This enhancement has been discussed in #129 and others primarily revolving around v2 conversations. @bentaber

@markhealey
Copy link
Member Author

Proposing this for a new version 1.3.4.

@brianbaker
Copy link
Member

Might consider solving #171 at the same time since its in the same code?

@markhealey
Copy link
Member Author

Good call, thanks for linking the issues.

@bentaber
Copy link
Contributor

I've only tested this in chrome, using the example container. Could use some help understanding how the jasmine tests are set up so I can try and add some for this.

@markhealey
Copy link
Member Author

@bentaber I added one test to give you an idea of how they're setup. See here.

The Jasmine tests rely on F2.min.js in both the headless and regular browser tests, so be sure to run grunt js before grunt test. If you want to use the regular browser, run grunt test-live and open http://localhosts:8080/tests.

@markhealey
Copy link
Member Author

After discussing the details of these changes, the F2 team sees them being released as a minor version change and not a patch. Therefore proposing version 1.4.0.

It's TBD whether this will get rolled into #142 or if #142 will become 1.5.0.

@markhealey
Copy link
Member Author

Quick update for those watching. We've been rolling in a few commits over the past two weeks (all listed here) in the load-deps-once branch. Prior to the first revision on October 19, we'd been tracking numerous issues revolving around the subject of "dependency management" in certain browsers. Since then, the App dependency loader has been reviewed and significantly updated to address a number of issues including both #182 and #171. There are a couple of new unit tests to help validate the changes and an informal changelog follows.

Finally, it is likely these updates (#184) will get merged into #142 for a final 1.4.0 release.

@markhealey
Copy link
Member Author

If you want to test out this load-deps-once version, use this version of F2.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants