Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axiom of electricity price was implemented as rdf:comment #1872

Open
5 tasks
l-emele opened this issue Jun 28, 2024 · 3 comments
Open
5 tasks

axiom of electricity price was implemented as rdf:comment #1872

l-emele opened this issue Jun 28, 2024 · 3 comments
Labels
[B] restructure Restructuring existing parts of the ontology oeo-social changes the oeo-social module To do Issues that haven't got discussed yet

Comments

@l-emele
Copy link
Contributor

l-emele commented Jun 28, 2024

Description of the issue

For some reason the the axiom 'electricity price' 'has unit' some 'currency per unit' was implemented as rdf:comment:
grafik

This is clearly a bug!

Ideas of solution

If you already have ideas for the solution describe them here

Workflow checklist

  • I discussed the issue with someone else than me before working on a solution
  • I already read the latest version of the workflow for this repository
  • The goal of this ontology is clear to me

I am aware that

  • every entry in the ontology should have a definition
  • classes should arise from concepts rather than from words
@l-emele l-emele added [B] restructure Restructuring existing parts of the ontology oeo-social changes the oeo-social module To do Issues that haven't got discussed yet labels Jun 28, 2024
@stap-m
Copy link
Contributor

stap-m commented Jul 1, 2024

I think we added this as comment because we wanted to wait for a solution for composed units. This needs some discussion.

@l-emele
Copy link
Contributor Author

l-emele commented Jul 1, 2024

Okay, then this explanation should be part of the comment. Like this, it simply looks like an implementation error.

@stap-m
Copy link
Contributor

stap-m commented Sep 4, 2024

This might be solved by #1911

EDIT: or not... We'd need a kind of "relational unit", not just a quantity value.

@stap-m stap-m changed the title Bug: axiom of electricity price was implemented as rdf:comment axiom of electricity price was implemented as rdf:comment Sep 4, 2024
@l-emele l-emele added this to the oeo-release-2.5.0 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[B] restructure Restructuring existing parts of the ontology oeo-social changes the oeo-social module To do Issues that haven't got discussed yet
Projects
Status: To do
Development

No branches or pull requests

2 participants