Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback course 06: Comparing data - Enable scenario projection comparison #174

Open
han-f opened this issue Apr 17, 2023 · 7 comments
Open
Assignees
Labels

Comments

@han-f
Copy link
Contributor

han-f commented Apr 17, 2023

Please review course 06 : https://openenergyplatform.github.io/academy/courses/06_enable_comparisons/
and provide your feedback below as comments. Feedback can include pointing out errors (such as broken links, things that do not work as described) any suggestions for improvements, things that you are expecting from such a course but find they are missing etc.

@han-f
Copy link
Contributor Author

han-f commented Apr 17, 2023

@wingechr and @l-emele : I assigned you first, as this is based on our derivation of key parameters and variables. It would be great if you could have a look at how the draft turned out. Please also feel free to edit the course in case you see the need to add / change. Thanks.

@han-f han-f changed the title Feedback course 06: Upload - Contribute data to the OEP Feedback course 06: Comparing data - Enable scenario projection comparison Apr 17, 2023
@l-emele
Copy link
Contributor

l-emele commented Apr 19, 2023

I've improved a few things, mainly links to more specific OEO classes.

@u-mueller
Copy link

Shall we link to feedback issues here on github in the courses themselves, e.g. in the about section of each course?

@han-f
Copy link
Contributor Author

han-f commented May 17, 2023

@u-mueller good idea, I think I'll implement this right away.

@han-f
Copy link
Contributor Author

han-f commented May 17, 2023

I have implemented it - both on the very top of each course and in the about section.

@Ludee Ludee added help wanted Extra attention is needed documentation labels Jun 14, 2023
@wingechr wingechr removed their assignment Feb 25, 2024
@flohrreija-oeko
Copy link
Collaborator

Clear, easy to understand and well structured course! The linked definitions to the OEO are very complete and consistent.

I only found "Heating degree days" and "cooling degree days" not included in the OEO and, accordingly not linked here. I would suggest to include it in the OEO and link it here as it is not a trivial quantity.

@l-emele
Copy link
Contributor

l-emele commented Jul 16, 2024

Thanks for the feedback.

For reference: There we have an issue in the oeo repo on heating and cooling degree days OpenEnergyPlatform/ontology#1397, however there has not much happened in recent time (part of that because HDD and CDD are a bit a weird concepts).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants