Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think bug in previewing other branches #250

Open
odscjames opened this issue Jan 19, 2022 · 1 comment
Open

Think bug in previewing other branches #250

odscjames opened this issue Jan 19, 2022 · 1 comment

Comments

@odscjames
Copy link
Contributor

  1. use /_preview_branch/jamestest to load a different branch where the title of one of the lists has changed
  2. try and find the list you edited and end up on /results page listing it and other options
  3. the title has not changed - bug!
  4. click on the list to go to the list page eg /list/GB-COH
  5. the title will have changed

view.results() function

Should be:

'all_results': filter_and_score_results(query, use_branch)

I think?

And maybe:

    context['lookups'] = get_lookups(query, use_branch)
@odscjames
Copy link
Contributor Author

Time lost to bug, forgetting about it and rediscovering it again += 25 mins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant