Skip to content

Latest commit

 

History

History
53 lines (37 loc) · 2.22 KB

Step_5_Merging _Pull_Request.md

File metadata and controls

53 lines (37 loc) · 2.22 KB
Raw
layout title nav_order
default
Step 5 - Merging Pull Request
12

Creating a Pull Request

Now that you have made some changes you now need to push your changes back to the shared repository for collaboration.

GitHub Workflow

GitHub Workflow

Review - When you are making line comments, you can also choose to Start a Review. When you create a review, you can group many line comments together with a general message: Comments, Approve, or Request Changes. Reviews have special power in GitHub when used in conjunction with protected branches.

PR Review

One of the best ways to ensure code quality is to make peer reviews a part of every Pull Request.

  1. Click the Pull Request tab.
  2. Use the Author drop down to locate your pull request.
  3. Click the Files Changed tab.
  4. Hover over a single line in the file to see the blue +. Click the + to add a line comment.
  5. Comment on the line and click Start a review.
  6. Add additional line comments to the pull request.
  7. Click Review changes in the top right corner.
  8. Choose whether to Approve or Request changes
  9. Enter a general comment for the review.
  10. Click Submit review
  11. Click the Conversation tab to check out your completed review.