Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] GeneralUnit has no _to_default_unit() method #381

Closed
lohedges opened this issue Jan 13, 2025 · 0 comments · Fixed by #385
Closed

[BUG] GeneralUnit has no _to_default_unit() method #381

lohedges opened this issue Jan 13, 2025 · 0 comments · Fixed by #385
Assignees
@lohedges
Labels
bug Something isn't working

Comments

@lohedges
Copy link
Contributor

Since, by definitiion, GeneralUnit is already in default internal units, there is no _to_default_unit() method. This causes issues when a GeneralUnit instance is treated like the other unit-based types. An easy fix is to just add a _to_default_unit() method that returns self, so it can be treated the same way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lohedges lohedges

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues 381, 382, and add a Mass type OpenBioSim/biosimspace
1 participant
@lohedges