Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect target_lock() implementation for ARM without OS in dual processor system #359

Open
sebhub opened this issue Jun 18, 2018 · 1 comment
Open

Incorrect target_lock() implementation for ARM without OS in dual processor system #359

sebhub opened this issue Jun 18, 2018 · 1 comment

Comments

@sebhub
Copy link
Contributor

sebhub commented Jun 18, 2018

The target_lock() implementation in altera-c5socarm/lock-dualprocnoos.c is broken on SMP systems. For a primitive SMP lock, see:

https://en.wikipedia.org/wiki/Test_and_test-and-set
@sebhub
Copy link
Contributor Author

sebhub commented Jun 18, 2018

The xilinx-microblaze/lock-dualprocnoos.c and altera-nios2/lock-dualprocnoos.c seem to be copy and paste versions of this. They are also broken. At which level should the target_lock() ensure mutual exclusion? How is this related to dualprocshm_targetAcquireLock()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sebhub