Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add github action GTest #54

Merged
merged 5 commits into from
Nov 28, 2023

Conversation

lqxhub
Copy link
Collaborator

@lqxhub lqxhub commented Nov 26, 2023

在GitHub action里添加 GTEST测试,
关闭依赖库的TEST 编译,
修复 gcc12下 release模式下编译错误 -Wno-restrict

@github-actions github-actions bot added ✏️ Feature New feature or request 🧹 Updates This will not be worked on labels Nov 26, 2023
@lqxhub
Copy link
Collaborator Author

lqxhub commented Nov 26, 2023

想起一件事, 要不要加上 在 Ubuntu和 centOS 环境的编译

build.sh Outdated
@@ -14,5 +31,12 @@ fi
echo "BUILD_TIME:" $BUILD_TIME
echo "COMMIT_ID:" $SHORT_COMMIT_ID

cmake -DCMAKE_BUILD_TYPE=Release -DBUILD_TIME=$BUILD_TIME -DGIT_COMMIT_ID=$SHORT_COMMIT_ID -S . -B build
cmake --build build -- -j 32
cmake -DCMAKE_BUILD_TYPE=debug -DBUILD_TIME=$BUILD_TIME -DGIT_COMMIT_ID=$SHORT_COMMIT_ID -S . -B build
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里要改回release不,还有就是我之前想的一个是这里要不要接收一个参数来选择编译的模式,默认是release

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

疏忽了, 原来在我本地用release模式编译不过, 后来给gcc加了一个参数可以了, 这里忘记改回去了, 等我晚上回去改一下

要不要接收一个参数来选择编译的模式

我想的是加一个环境变量如何, 通过 export PIKIWIDB=DEBUG 设置环境变量, build.sh中读取环境变量, 如果读到DEBUG 使用debug模式, 没有就默认 release模式

这个方案怎么样

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

疏忽了, 原来在我本地用release模式编译不过, 后来给gcc加了一个参数可以了, 这里忘记改回去了, 等我晚上回去改一下

要不要接收一个参数来选择编译的模式

我想的是加一个环境变量如何, 通过 export PIKIWIDB=DEBUG 设置环境变量, build.sh中读取环境变量, 如果读到DEBUG 使用debug模式, 没有就默认 release模式

这个方案怎么样

感觉挺好的,之前看有一些项目可以用类似这种sh build.sh --debug这种来debug编译,或许可以参考下

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉挺好的,之前看有一些项目可以用类似这种sh build.sh --debug这种来debug编译,或许可以参考下

感觉这个比环境变量要好, 可以改成这种方式

@AlexStocks AlexStocks merged commit 352c5ca into OpenAtomFoundation:unstable Nov 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Feature New feature or request 🧹 Updates This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants