Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate creating a branch when source has no instantiated graph #160

Open
dlamoris opened this issue Oct 7, 2024 · 0 comments
Open

Validate creating a branch when source has no instantiated graph #160

dlamoris opened this issue Oct 7, 2024 · 0 comments

Comments

@dlamoris
Copy link
Contributor

dlamoris commented Oct 7, 2024

In BranchWrite, if the source has no instantiated graph available, it creates a lock and a Model graph instead of a new branch and staging graph.

This condition currently never happens because a commit lock is created after each commit, so on creating a branch or lock there's always a graph to copy from.

Relevant code:
case where it creates a branch staging graph: https://github.com/Open-MBEE/flexo-mms-layer1-service/blob/develop/src/main/kotlin/org/openmbee/flexo/mms/routes/ldp/BranchWrite.kt#L255
case where it creates a lock if there's no existing graph to copy: https://github.com/Open-MBEE/flexo-mms-layer1-service/blob/develop/src/main/kotlin/org/openmbee/flexo/mms/routes/ldp/BranchWrite.kt#L371

related to #86

@dlamoris dlamoris added this to Flexo Oct 7, 2024
@github-project-automation github-project-automation bot moved this to New in Flexo Oct 7, 2024
@dlamoris dlamoris moved this from New to Backlog in Flexo Oct 7, 2024
@dlamoris dlamoris mentioned this issue Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant